Shouldn't "Design Considerations" be discussed before development begins? Shouldn't "Functionality Review" be the QA team's responsibility?
Overall, the article is good, but it seems to imply that the PR reviewer should essentially reimplement the feature. This involves checking business requirements, considering edge cases, and evaluating the best implementation, which seems like a significant undertaking.
For me, this sounds like a full-time job with scalability issues. It's hard to imagine reviewing many PRs following this guide. Also, the reviewer would need to be skilled enough to quickly assess a PR, especially since they could represent 2-3 days of coding.
I believe it's better to share coding standards and have ad-hoc discussions with peers when questions arise about best practices or approaches. I typically screen for edge cases, coding best practices, complexity, and extensibility.
I'd be interested in discussing your approach further.
Im gonna try using this article as prompt for review using AI tools 👌
I liked this, Fernando. It’s clear and practical.
I think structured feedback over style preferences is critical to building a great team.
Thanks so much for the shoutout!
Thanks for the mention.
Nice
Shouldn't "Design Considerations" be discussed before development begins? Shouldn't "Functionality Review" be the QA team's responsibility?
Overall, the article is good, but it seems to imply that the PR reviewer should essentially reimplement the feature. This involves checking business requirements, considering edge cases, and evaluating the best implementation, which seems like a significant undertaking.
For me, this sounds like a full-time job with scalability issues. It's hard to imagine reviewing many PRs following this guide. Also, the reviewer would need to be skilled enough to quickly assess a PR, especially since they could represent 2-3 days of coding.
I believe it's better to share coding standards and have ad-hoc discussions with peers when questions arise about best practices or approaches. I typically screen for edge cases, coding best practices, complexity, and extensibility.
I'd be interested in discussing your approach further.